Skip to content

subint normalisation using vectorized peak-to-peak scaling#12

Merged
v-morello merged 1 commit intov-morello:masterfrom
ydejiang:master
Dec 3, 2025
Merged

subint normalisation using vectorized peak-to-peak scaling#12
v-morello merged 1 commit intov-morello:masterfrom
ydejiang:master

Conversation

@ydejiang
Copy link
Contributor

@ydejiang ydejiang commented Dec 2, 2025

Hi Morello,
This PR updates the sub-integration normalisation in the diagnostic plot.

  • Keeps the original peak-to-peak scheme (per-subint scaling), which produced clearer compared with whitening (in my test!).
  • Rewritten following your suggestions:
    • fully vectorised NumPy implementation
    • no Python loops
    • no atol-based workaround
    • no extra array allocation

Only the normalisation step is changed.

Thanks again for the guidance!

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.96%. Comparing base (50aaf4b) to head (a3169ee).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   93.94%   93.96%   +0.01%     
==========================================
  Files          33       33              
  Lines        1800     1805       +5     
  Branches      139      139              
==========================================
+ Hits         1691     1696       +5     
  Misses         70       70              
  Partials       39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@v-morello v-morello merged commit 033ffbe into v-morello:master Dec 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants